Different studies have produced conflicting results regarding the association between smoking and diabetes mellitus, and detailed analysis of this issue in Chinese males based on nationwide samples is lacking. We explored the association between cigarette smoking and newly-diagnosed diabetes mellitus (NDM) in Chinese males using a population-based case-control analysis; 16,286 male participants without previously diagnosed diabetes were included. Prediabetes and NDM were diagnosed using the oral glucose tolerance test. The cohort included 6,913 non-smokers (42.4%), 1,479 ex-smokers (9.1%) and 7,894 current smokers (48.5%). Age-adjusted glucose concentrations (mmol/L) were significantly lower at fasting and 120 min in current smokers than non-smokers (5.25 vs. 5.30, 6.46 vs. 6.55, respectively, both P < 0.01). After adjustment for demographic and behavioral variables (age, region, alcohol consumption status, physical activity, education, and family history of diabetes), logistic regression revealed significant negative associations between smoking and NDM in males of a normal weight (BMI < 25 kg/m2: adjusted odds ratio [AOR] = 0.75, P = 0.007; waist circumference < 90 cm: AOR = 0.71, P = 0.001) and males living in southern China (AOR = 0.75, P = 0.009), but not in males who were overweight/obese, males with central obesity, or males living in northern China. Compared to non-smokers, current smokers were less likely to be centrally obese or have elevated BP (AOR: 0.82 and 0.74, both P < 0.05), and heavy smokers (≥ 20 pack-years) were less likely to have elevated TG (AOR = 0.84, P = 0.012) among males of a normal weight. There were no significant associations between quitting smoking and metabolic disorders either among males of a normal weight or males who were overweight/obese. In conclusion, smokers have a lower likelihood of NDM than non-smokers among Chinese males with a lower BMI/smaller waist.