Chloride attack is considered one of the most threatening deterioration mechanisms in concrete. Any cracks or other imperfections on the surface open up additional routes for chloride intrusion. This paper develops existing anisotropic (1-D) and isotropic (2-D) models for chloride diffusion in concrete with cracks by considering the crack shape and roughness. In order to verify the proposed model, concrete samples with crack widths from 0.0 to 0.4 mm were prepared and the chloride diffusion coefficients under steady-state conditions evaluated. The proposed model for a wedge-shaped model with roughness reduced chloride diffusion and provided more reasonable results than previous models based on rectangular shaped cracks with no roughness, which have tended to overestimate the effect. Our results revealed that including roughness in the model produced a 10%–20% reduction in chloride diffusion.